Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse: Downgrade NM passthrough warning to debug #384

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Jul 20, 2023

Description

With the NetworkManager integration in place there will be many more cases where "nm-devices" are used, and we don't want to spam system logs with our warnings.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

With the NetworkManager integration in place there will be many more
cases where "nm-devices" are used, and we don't want to spam system
logs with our warnings.
@slyon slyon requested a review from daniloegea July 20, 2023 12:16
@slyon
Copy link
Collaborator Author

slyon commented Jul 20, 2023

@daniloegea WDYT?

Copy link
Collaborator

@daniloegea daniloegea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it :D lgtm

@daniloegea daniloegea merged commit 22b8bfb into canonical:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants